Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder steps in *Builder so that immutable inputs occur before mutable inputs #67

Open
realityforge opened this issue Jun 16, 2020 · 0 comments
Labels
api_change Changes the API of components enhancement

Comments

@realityforge
Copy link
Member

It seems reasonable that components should have immutable/key contributing props earlier in the *Builder classes than later. We could do this by reordering the inputs when generating the builder or by detecting the declaration ordering and objecting if it does not follow this convention.

detecting ordering is complex as we would likely want to guarantee an ordering such as

  • source=context, immutable=true
  • source=context, immutable=false
  • source=user, immutable=true
  • source=user, immutable=false

However, we would still need to do this for each level of inheritance hierarchy and this seems complex and overly burdensome on the developers.

@realityforge realityforge added enhancement api_change Changes the API of components labels Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api_change Changes the API of components enhancement
Development

No branches or pull requests

1 participant