Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate warnings on unnecessary package access methods and fields in views #75

Open
realityforge opened this issue Jun 26, 2020 · 1 comment
Labels
api_change Changes the API of components

Comments

@realityforge
Copy link
Member

A few bugs have been identified as a result of other objects invoking methods on @View annotated methods. We could generate warnings if a @View declares a package access method or package-access field where it is not necessary for it to be package access. Essentially this would involve generating warnings for package-access methods and fields unless they are annotated with either an arez annotation or a react4j annotation.

This warnings should be suppress-able just in case there is a valid reason that we have yet to think of

@realityforge realityforge added the api_change Changes the API of components label Jun 26, 2020
@realityforge
Copy link
Member Author

We should also generate a warning if any non-private class is enclosed within the @View annotated type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api_change Changes the API of components
Development

No branches or pull requests

1 participant