Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint configuration #50

Closed
luizbaldi opened this issue Jul 16, 2019 · 6 comments
Closed

ESLint configuration #50

luizbaldi opened this issue Jul 16, 2019 · 6 comments
Assignees

Comments

@luizbaldi
Copy link
Member

That'd be good to have ESLint configured for the project, so we can have a pattern for the codebase and help more new contributors.

Any thoughts on famous JavaScript/React style guides to be followed? (like Airbnb or Standard)

@arturbien
Copy link
Member

I always see people using AirBnb settings so I think it might be the best option since many people are used to these settings. But let's wait for some more opinions

@vnallamhawk
Copy link

Hello @luizbaldi can i take this up ?

@luizbaldi
Copy link
Member Author

Hello @luizbaldi can i take this up ?

Of course! Feel free to ping us on the discord channel if you need anything :)

@vnallamhawk
Copy link

I am not sure of what is meant by discord channel. Shall we go with airbnb initially ? Should I raise a pull request to master branch with my changes ?

@arturbien
Copy link
Member

@vnallamhawk yeah lets do AirBnb, and you can do pull request to master too 🤟🏻

@arturbien
Copy link
Member

closed in #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants