Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Fill for Line graph not working #1029

Closed
1 task
AdamVerner opened this issue Mar 9, 2022 · 2 comments
Closed
1 task

[Bug]: Fill for Line graph not working #1029

AdamVerner opened this issue Mar 9, 2022 · 2 comments
Labels

Comments

@AdamVerner
Copy link

Would you like to work on a fix?

  • Check this if you would like to implement a PR, we are more than happy to help you go through the process.

Current and expected behavior

fill: true (and backgroundColor) should add background to the area below line. This is working, when i use Chart.js directly, but not when i use the bindings to pass the datasets. Doesn't work in the examples either.

image

Reproduction

https://codesandbox.io/s/busy-flower-6g0xyz?file=/App.tsx

chart.js version

3.7.1

react-chartjs-2 version

4.0.1

Possible solution

No response

@AdamVerner AdamVerner added the bug label Mar 9, 2022
@dangreen
Copy link
Collaborator

dangreen commented Mar 9, 2022

https://react-chartjs-2.js.org/faq/fill-property

@dangreen dangreen closed this as completed Mar 9, 2022
@AdamVerner
Copy link
Author

Sorry, i somehow completely missed that, Thanks.

Anyway, wouldn't it be good idea to use the Filler in the example if the backgroundColor property is set as well? That's probably what confused me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants