Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is step 3 in deploying to Heroku neccesary? #13

Closed
kenfehling opened this issue Jun 2, 2015 · 1 comment
Closed

Is step 3 in deploying to Heroku neccesary? #13

kenfehling opened this issue Jun 2, 2015 · 1 comment

Comments

@kenfehling
Copy link
Contributor

Run webpack . Commit and push the changes (I know, not the best idea).

I deployed right to Heroku without doing this and it seemed to work fine.
@choonkending
Copy link
Member

@kenfehling Good find!
We used to run webpack before I added webpack into the postinstall build step in package.json. Will remove it shortly!

choonkending added a commit that referenced this issue Jun 2, 2015
@choonkending
Update README for Deploy to Heroku
e297301 
#13
clarketm pushed a commit to clarketm/connect-reactGo-app that referenced this issue Sep 28, 2017
@choonkending
Update README for Deploy to Heroku
470c424 
reactGo/reactGo#13
noproblem23 added a commit to noproblem23/reactGo that referenced this issue Apr 21, 2023
@noproblem23
Update README for Deploy to Heroku
900285b 
reactGo/reactGo#13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kenfehling @choonkending