Simplify On Clause #423
Merged
Simplify On Clause #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a1b0c8d.
Doesn't yet pass tests. Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
* Replace both Action and Example with Statement Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
* Different kinds of statement sets are handled in each OnClause per the enclosing kind of definition. * Enforce the correct set of statements in parsing * Tests don't pass yet. Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Revised the AST and parsing rules to deal with On Clauses in a much simpler manner based on only conditional expressions, values and statements. The objective here is to capture the inter-context relationships but not become a complete programming language. AI can make up the difference. Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
There are still test failures: [error] Failed tests: [error] com.reactific.riddl.translator.hugo.HugoPassTest [error] (riddlc / Test / test) sbt.TestsFailedException: Tests unsuccessful [error] (prettify / Test / test) sbt.TestsFailedException: Tests unsuccessful [error] (hugo / Test / test) sbt.TestsFailedException: Tests unsuccessful [error] (testkit / Test / test) sbt.TestsFailedException: Tests unsuccessful [error] (passes / Test / test) sbt.TestsFailedException: Tests unsuccessful [error] Total time: 5 s, completed Aug 30, 2023, 2:16:23 PM Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
StatementValidationTest and HandlerValidationTest both pass now. Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace examples, expressions, and values with simple statements that express business logic and support cross-definition linkage (for validation). This change aims to simplify the pseudo-code in an On Clause so that it still exhibits referential links that can be validated and makes it far easier to write pseudo-code that some day LLMs can use to generate actual code.