Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert !commands to slash commands #131

Open
nickmccurdy opened this issue Dec 17, 2021 · 8 comments · May be fixed by #148 or #241
Open

Convert !commands to slash commands #131

nickmccurdy opened this issue Dec 17, 2021 · 8 comments · May be fixed by #148 or #241
Assignees
@nickmccurdy
Labels
enhancement New feature or request

Comments

@nickmccurdy
Copy link
Member

nickmccurdy commented Dec 17, 2021 •
edited

Inspired by #46

Application commands provide a better UX for running bot commands in Discord (fixing common issues of ours like moderators having to delete commands that users accidentally run) while also allowing for more relaxed bot permissions.

Once we upgrade to discord.js 13, we can use their registering slash commands example.
@nickmccurdy nickmccurdy added the enhancement New feature or request label Dec 17, 2021
@vcarl
Copy link
Member

vcarl commented Dec 17, 2021

This seems like one benefit we'd get by updating discord.js, maybe that's a better title?

@nickmccurdy
Copy link
Member Author

nickmccurdy commented Dec 18, 2021 •
edited

I'm intentionally keeping this as a separate issue, since this is more of a UX improvement and the handler format is not required in discord.js 13. Neither PR has this yet, and I might move the refactor to another PR anyway to make it easier to review.

@nickmccurdy nickmccurdy mentioned this issue Dec 19, 2021
Closed
@nickmccurdy

This comment has been minimized.

Sign in to view
@vcarl

This comment has been minimized.

Sign in to view
@vcarl vcarl changed the title Enable application commands Convert !commands to application/slash commands Dec 20, 2021
@nickmccurdy nickmccurdy self-assigned this Dec 30, 2021
This was referenced Jan 2, 2022
Closed
Closed
@nickmccurdy
Copy link
Member Author

nickmccurdy commented Jan 2, 2022 •
edited

Renaming to specifically use slash commands, since we don't seem to need the other application command types (user and message context menu commands) yet. Slash commands are specifically used when typing messages, which is most similar to how we're currently using the bot.

@nickmccurdy nickmccurdy changed the title Convert !commands to application/slash commands Convert !commands to slash commands Jan 2, 2022
@nickmccurdy nickmccurdy linked a pull request Jan 2, 2022 that will close this issue
Register slash commands #148
Draft
@Padmanabh82
Copy link

Ye, we need this

@nickmccurdy
Copy link
Member Author

What's the status of this? I noticed another PR got merged, but I'm not seeing our slash commands on Discord.

@vcarl
Copy link
Member

vcarl commented May 27, 2022 •
edited

I haven't made any changes to affect this, but I did implement command deployment in #198 which should facilitate this. Our only command atm is the anonymous report

reactibot/scripts/deploy-commands.ts

Line 27 in 7f3bbcd

const cmds: CommandConfig[] = [report];

@vcarl vcarl linked a pull request Jul 28, 2022 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickmccurdy nickmccurdy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@nickmccurdy @vcarl @Padmanabh82