Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query params in package name for module_from_template not stripped #455

Closed
rmorshea opened this issue Jul 29, 2021 · 0 comments · Fixed by #456
Closed

Query params in package name for module_from_template not stripped #455

rmorshea opened this issue Jul 29, 2021 · 0 comments · Fixed by #456

Comments

@rmorshea
Copy link
Collaborator

rmorshea commented Jul 29, 2021

The following call:

module_from_template("react", "@blueprintjs/core?module", cdn="https://unpkg.com")

Ends up saving a file with the name @blueprintjs/core?module.js when it should actually have stripped the query parameters and just saved @blueprintjs/core.js as the file name. This causes an issue when the browser tries to load the file from URL http://.../@blueprintjs/core?module.js and the server tries to look for a file called @blueprintjs/core (since the query params are not part of the path).

Perhaps we can use urllib to help parse this correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant