Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use default export in react template #502

Closed
rmorshea opened this issue Sep 3, 2021 · 0 comments · Fixed by #503
Closed

Cannot use default export in react template #502

rmorshea opened this issue Sep 3, 2021 · 0 comments · Fixed by #503
Labels
type-feature About new capabilities

Comments

@rmorshea
Copy link
Collaborator

rmorshea commented Sep 3, 2021

Current Situation

Right now, you can't use the default export from a module that came from module_from_template.

Proposed Changes

The only option I see is to include a react-default-export template that includes the default export.

Implementation Details

I'd rather not duplicate code, so maybe we can have a VERY primitive templating language, where a line starting with $TEMPLATE: ... indicates that the contents of file to follow should be inserted at that point.

If the templates get any more complicated that this we should consider a different solution.

@rmorshea rmorshea added the flag-triage Not prioritized. label Sep 3, 2021
@rmorshea rmorshea mentioned this issue Sep 3, 2021
@rmorshea rmorshea added type-feature About new capabilities and removed flag-triage Not prioritized. labels Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-feature About new capabilities
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant