Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHAPIDemo spinner showed with no end #129

Closed
yzlin opened this issue Nov 25, 2012 · 0 comments · Fixed by #223
Closed

GHAPIDemo spinner showed with no end #129

yzlin opened this issue Nov 25, 2012 · 0 comments · Fixed by #223
Assignees
@jspahrsummers
Labels
bug
Milestone
1.0

Comments

@yzlin
Copy link

yzlin commented Nov 25, 2012

I checked out the latest commit and tried to login with invalid account/password many times. The spinner hid the first time but remained unhidden since the second time. Looks like the subscription wasn't triggered.
@ghost ghost assigned jspahrsummers Dec 25, 2012
@jspahrsummers jspahrsummers mentioned this issue Dec 25, 2012
Merged
@jifang jifang mentioned this issue Feb 4, 2016
Closed
andersio pushed a commit that referenced this issue Sep 22, 2016
@dmcrodrigues @RuiAAPeres
Changed rex_text bindable property to be an optional string (#133)
0a1927d 
* Changed `rex_text` bindable property to be an optional string

Fixes #125, #129.

* Updated UILabel's text property test to include nullability
andersio pushed a commit that referenced this issue Sep 22, 2016
@dmcrodrigues @RuiAAPeres
Add bindable property to wrap a control's value (#119)
4a3bd79 
* Provide a `setUp` to properly configure the associated property

The introduced `setUp` is extremely helpful to setup any signals that may
affect the property once.

* Add bindable property to wrap a control's value

This property is common to every `UIControl` and can be used by
providing a getter and a setter for the value wrapped. This property
uses `UIControlEvents.ValueChanged` and `UIControlEvents.EditingChanged`
events to detect changes and keep the value up-to-date. This kind of
logic can be reused instead of being defined and used for each control.

* Use `setUp` to install the dependent signal of `rex_dismissAnimated`

This prevents repetition of events in cases where the property is
accessed more than once (each access adds a new `rac_signalForSelector`
for the dismiss of the view controller).

* Fixes #129 - UITextField's text bindable property should be of optional type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jspahrsummers jspahrsummers

Labels
bug
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Remove RACAsyncCommand, fix infinite spinner in GHAPIDemo ReactiveCocoa/ReactiveCocoa
3 participants
@joshaber @yzlin @jspahrsummers