Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add podspec file in git repo #70

Closed
prabirshrestha opened this issue Oct 2, 2012 · 7 comments
Closed

add podspec file in git repo #70

prabirshrestha opened this issue Oct 2, 2012 · 7 comments
Milestone

Comments

@prabirshrestha
Copy link

This would easily allow us to consume ReactiveCocoa by adding the following code in our Podfile.

platform :ios
pod "ReactiveCocoa", :git => 'https://github.com/github/ReactiveCocoa.git', :tag => 'v0.8.0'
@sarahhodne
Copy link
Contributor

This would really help using ReactiveCocoa with CocoaPods. I would like using master, but there's not really a way to do that now without cloning ReactiveCocoa. I'm using Mantle as well in my project, which is in my CocoaPods repo, but they don't play nicely together as they have some shared dependencies, which leads to duplicated symbols in the linked binary.

@jspahrsummers
Copy link
Member

Isn't CocoaPods supposed to handle that case? I thought that was a pretty big selling point. In any case, linking without -all_load should solve duplicate symbol errors.

We've been pretty diligent about tagging, and others (like @irrationalfab) have been maintaining a Podspec external to the repo.

@jspahrsummers
Copy link
Member

So, just to clarify: are tags usable without the podspec file being in the repo?

@prabirshrestha
Copy link
Author

@irrationalfab thoughts on this?

@dannygreg
Copy link
Member

As far as I understand in our current state we are 100% usable with CocoaPods right now. I see no need to add another file to the repo.

@fabiopelosin
Copy link

This would really help using ReactiveCocoa with CocoaPods. I would like using master, but there's not really a way to do that now without cloning ReactiveCocoa.

I agree with @jspahrsummers that they have been doing a great job with tagging so I personally see little need of using the head of master. In any case, if you need it, you can create a custom podspec in a private repo (however you might need to update the file patterns from time to time).

Isn't CocoaPods supposed to handle that case? I thought that was a pretty big selling point.

If a library is added to a project manually CocoaPods it is not aware of it and doesn't have the information necessary to cross resolve dependencies.

So, just to clarify: are tags usable without the podspec file being in the repo?

Yes. When a library is properly tagged the only advantage of having a podspec in the repo is that users can edit the library from their final application (:local option) to facilitate the preparation of a pull request. However if the podspec is added to the root of the repo it is expected to be maintained, otherwise it is useless.

@jspahrsummers
Copy link
Member

@irrationalfab Thanks for the summary and your work on the podspec!

I agree with @dannygreg, so I'm going to close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants