Rename Event.failed to Event.error

[inamiy]

This is just a matter of taste, but observer.sendFailed() has been renamed to observer.send(error:), so I think Event.failed should be renamed to Event.error as well (and also other methods like on(failed:)).

Or, renaming observer.send(error:) to observer.send(failed:) improves consistency too.
(I prefer send(error:) though)

[andersio]

The event was intentionally (re)named failed as being one of the terminating event. Though I agree we should take a second look at the consistency.

ReactiveCocoa/ReactiveCocoa#2505
ReactiveCocoa/ReactiveCocoa#2360
ReactiveCocoa/ReactiveCocoa#2349

[ikesyo]

And also #8.

[mdiep]

I think it makes sense as-is. failed is the event; error is the instance that initiates/describes it. An error causes the stream to fail.

[inamiy]

Thanks for references.
I still find the naming inconsistency in Observer.swift#L78-L104 ("send" should be followed by event name), but it might be an exception for argument label case.

Anyway, this is too trivial issue to discuss, so I will close.