feat: add s3 api. #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
合并到develop分支吧 |
kevinten10
requested changes
Jun 28, 2022
| @@ -55,7 +55,7 @@ For a Maven project, add the following to your `pom.xml` file: | |||
| <dependency> | |||
| <groupId>group.rxcloud</groupId> | |||
| <artifactId>cloud-runtimes-api</artifactId> | |||
| <version>1.15.RELEASE</version> | |||
| <version>1.16-SNAPSHOT</version> | |||
| @@ -69,6 +69,6 @@ For a Gradle project, add the following to your `build.gradle` file: | |||
| dependencies { | |||
| // ... | |||
| // https://mvnrepository.com/artifact/group.rxcloud/cloud-runtimes-api | |||
| implementation group: 'group.rxcloud', name: 'cloud-runtimes-api', version: '1.15.RELEASE' | |||
| implementation group: 'group.rxcloud', name: 'cloud-runtimes-api', version: '1.16-SNAPSHOT' | |||
| * @param putObjectInput | ||
| * @return | ||
| */ | ||
| PutObjectOutput putObject(PutObjectInput putObjectInput); |
There was a problem hiding this comment.
如果考虑未来有异步调用，建议和其他api保持一致，使用mono/flux。
这样既可以有异步，又可以有同步。
There was a problem hiding this comment.
我觉得还是考虑异步吧，s3不像redis，redis确保响应很快所以就做成同步的了，异步意义不大。
但s3会涉及到长时间的大数据传输，如果不支持异步，未来可能会遇到瓶颈。
added 2 commits
June 30, 2022 16:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add s3 api.
Issue reference
#48
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: