Github signup does not work

[synox]

I get redirected to an empty page after github auth.

[jboner]

@synox Is this still the case?

[synox]

still the same for me.

[jboner]

When you refresh the site, have you been added to the signatories page?

[synox]

No, still not on the list

[jboner]

@jroper Any ideas?

[jroper]

Hi @synox,

I can only reproduce this if I try to access the website using https, GitHub sign in redirects you back to the http site which is not allowed to access the window opener because it was https. Doing so however requires ignoring an SSL error saying that the domain name is wrong. Did you do this? Or do you plugins that might be automatically switching you to https? We don't support https on reactive manifesto at the moment.

Other possibilities include using a different domain name to access the site (though I'm not sure how you could have done that accidentally), having a JavaScript disabled (though this would probably have prevented you from even attempting to log in in the first place), or having some weird browser security configuration that's blocking child windows from accessing their opener.

If it's none of the above, then can you answer the questions below:

• Does it just happen in Firefox, or does it happen in all browsers?
• What version of Firefox are you using?
• When you get the blank page, are there any errors in the JavaScript console (accessible through the developer tools - ie right click on the page and click "Inspect element", then click on the console tab)? If so, please paste them in full here.

Cheers,

James

[synox]

I did some more testing. I did't have a "Name" in my Github Account.

When I add a name in the profile it works! Does a missing name trigger an error?

[jroper]

Thanks @synox, that would likely explain it, our parsing of GitHub profile data assumes that the name field will always be present. I'll update it to make it optional, and I'll also update the UI so that it renders any errors encountered at this step, this will make diagnosis of similar errors easier in future.

[jroper]

Issue fixed here:

reactivemanifesto/website-manifesto@e4af5af

Also, now error reporting is better, this is the message you would see now (if I hadn't have fixed the bug):