Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform Tree Test #177

Closed
hutterm opened this issue Nov 6, 2018 · 1 comment · Fixed by #230
Closed

Transform Tree Test #177

hutterm opened this issue Nov 6, 2018 · 1 comment · Fixed by #230
Labels

Comments

@hutterm
Copy link
Contributor

hutterm commented Nov 6, 2018

https://github.com/RolandPheasant/DynamicData/blob/447b9c1642f0214fdc4e0a4351a25bb352c2ac1e/DynamicData.Tests/Cache/TransformTreeFixture.cs#L133-L134

was reading up on these tree functions and wondered if this is not supposed to be

        _sourceCache.AddOrUpdate(minion);
        _sourceCache.AddOrUpdate(boss);

ie adding the minion first and the boss second... otherwise I don't see any difference between AddMissingParent() and AddMissingChild()

@RolandPheasant
Copy link
Collaborator

It has been years since I looked at TransformToTree so off the top off my head I cannot say,

@lock lock bot added the outdated label Sep 8, 2019
@lock lock bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants