Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to vertx version 4 #22

Open
deedarb opened this issue Dec 15, 2020 · 7 comments
Open

Migrate to vertx version 4 #22

deedarb opened this issue Dec 15, 2020 · 7 comments

Comments

@deedarb
Copy link
Contributor

deedarb commented Dec 15, 2020

No description provided.

@romalev
Copy link
Member

romalev commented Dec 18, 2020

yes indeed - this has to be done. @deedarb - feel free to contribute.

@deedarb
Copy link
Contributor Author

deedarb commented Feb 22, 2021

i've seen hazelcast, infinispan implementation for vertx 4.
Planning to implement for consul, but not sure about clusterHost and clusterPublicHost in new ClusterManager SPI.
Should i implement them or no?
Hazelcast starts "agent" with vertx instance, but consul do not, zookeeper is similar to consul and there is no implementations for those methods in zookeeper.

@deedarb
Copy link
Contributor Author

deedarb commented Mar 3, 2021

@vietj could you help me with understanding clusterHost & clusterPublicHost, if i understand correctly
If the cluster manager has its own server for data/membership, this returns the host it is listening to. When users don't configure the eventbus cluster host, the value will serve as a default. Returns: null if the cluster manager does not start a server or the host couldn't be determined

vertx instance will not start consul agent so i should not override clusterHost?
If the cluster manager has its own server for data/membership, this returns the host it advertises to other nodes. When users don't configure the eventbus cluster public host, the value will serve as a default. Returns: null if the cluster manager does not advertise a host that is different from the cluster host or the public host couldn't be determined
this is not clear for me: how to decide if "cluster manager does not advertise a host that is different" ?

@pmlopes
Copy link

pmlopes commented Mar 6, 2021

Tagging @tsegismont for his input here.

@tsegismont
Copy link

@deedarb some cloud providers have network configurations that make you bind server sockets to a hostname that is not the name used by others to reach you from the outside (for security reasons).

Vert.x needs to know which hostname (cluster host) to use when binding the eventbus server socket. It also needs to know which hostname (public host) it should advertise to other Vert.x nodes.

@robertonav20
Copy link

There is some update for this task?

@deedarb
Copy link
Contributor Author

deedarb commented Jul 27, 2022

@robertonav20 I stopped migrating, planning to switch to quarkus + stork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants