Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build status badge is out of date #1471

Closed
eatdrinksleepcode opened this issue Sep 6, 2017 · 1 comment
Closed

Build status badge is out of date #1471

eatdrinksleepcode opened this issue Sep 6, 2017 · 1 comment
Assignees
Milestone

Comments

@eatdrinksleepcode
Copy link
Contributor

Do you want to request a feature or report a bug?

README bug

What is the current behavior?

The build status badge on the README.md is referring to the "ghuntley/reactiveui" project in AppVeyor, which is reporting the build status as "unknown".

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

See the repo home page

What is the expected behavior?

Presumably the build status badge should be referring to the "dotnetfoundation/reactiveui" project, which is running for PRs.

What is the motivation / use case for changing the behavior?

Radiating the status of the build is a good indicator of the status of the project to potential new contributors (and good motivation to keep the build green 😀)

Which versions of ReactiveUI, and which platform / OS are affected by this issue? Did this work in previous versions of ReativeUI? Please also test with the latest stable and development snapshot

N/A

Other information (e.g. stacktraces, related issues, suggestions how to fix)

I would submit the PR to fix it myself, but AppVeyor appears to want the internal project ID in the build status link, and I was not able to find that ID with a quick search. Someone with direct access to the AppVeyor build could probably find it faster.

@ghuntley
Copy link
Member

ghuntley commented Sep 8, 2017

Fixed in #1478 - thanks for reporting this. Small yet important contribution.

@ghuntley ghuntley closed this as completed Sep 8, 2017
@ghuntley ghuntley added this to the 8.0.0 milestone Sep 8, 2017
@lock lock bot added the outdated label Jun 25, 2019
@lock lock bot locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants