Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPF XAML designer broken when using RoutedViewHost #1696

Closed
glennawatson opened this issue Jul 26, 2018 · 3 comments
Closed

WPF XAML designer broken when using RoutedViewHost #1696

glennawatson opened this issue Jul 26, 2018 · 3 comments

Comments

@glennawatson
Copy link
Contributor

Do you want to request a feature or report a bug?
bug

What is the current behavior?
RoutedViewHost when in WPF design mode will have a error complaining about the lack of IActivationForViewFetcher

This is due to ModeDetector.InUnitTestRunner() is not detecting the design mode correctly.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

  1. Check out https://github.com/ApexAutomation/BaseApp
  2. Load the MainWindow in either the xaml designer or the blend designer inside visual studio.

What is the expected behavior?
That you can design using the xaml editor.

What is the motivation / use case for changing the behavior?
Fix previously working experiences for users. Fix user experience first found in https://stackoverflow.com/questions/51525704/using-reactiveui-v8-routedviewhost-in-wpf

Which versions of ReactiveUI, and which platform / OS are affected by this issue? Did this work in previous versions of ReativeUI? Please also test with the latest stable and development snapshot
RxUI 8.3.1 WPF

@ghuntley
Copy link
Member

👍

@Asesjix
Copy link
Contributor

Asesjix commented Aug 7, 2018

I do not think it's up to Mode.Detector.IsUnitTestRunner().
Because the Designer works with the current ReativeUI master.
I think the cause was the same issue as Issue #1016 which I fixed with PR #1651.
@glennawatson Can you verify that?

image

@glennawatson
Copy link
Contributor Author

This appears to be fixed with 8.4.1. Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants