Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReactiveUI.Samples.Basic has ReactiveUI.Testing in it. Required? #10

Closed
gordonwatts opened this issue Dec 31, 2013 · 5 comments · Fixed by #11
Closed

ReactiveUI.Samples.Basic has ReactiveUI.Testing in it. Required? #10

gordonwatts opened this issue Dec 31, 2013 · 5 comments · Fixed by #11
Labels
outdated

Comments

@gordonwatts
Copy link
Contributor

It seems like it has the two testing packages (from Rx and from ReactiveUI), but removing them doesn't affect the sample. Extra?
@anaisbetts
Copy link
Member

@gordonwatts Probably somebody just included the ReactiveUI top-level package because they were lazy (entirely reasonable). You could replace it

@gordonwatts
Copy link
Contributor Author

I could remove it as part of the other PR... if you want to keep them separate I can generate a new PR when the other is done. Whatever you like.

@anaisbetts
Copy link
Member

@gordonwatts You can put it together

@gordonwatts
Copy link
Contributor Author

Well, that is a bit embarrassing. Apparently, I've already committed those changes to that PR - so it is ready to go as it stands. I checked other projects as well - seems fine. So I think that PR is ready to go.

@anaisbetts
Copy link
Member

@gordonwatts Hah! No worries :)

@gordonwatts gordonwatts mentioned this issue Jan 8, 2014
Merged
@lock lock bot added the outdated label Jun 24, 2019
@lock lock bot locked and limited conversation to collaborators Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
2 participants
@anaisbetts @gordonwatts