New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] navigationService.PopPage does not trigger WhenNavigatedTo #190
Comments
Hey @thor089 👋, Thank you for opening an issue. We will get back to you as soon as we can. Also, check out our Open Collective and consider contributing financially. https://opencollective.com/reactiveui
|
@thor089 Thanks for reporting this. I will probably work a fix in this weekend. |
Priority |
@RLittlesII: Thank you very much! |
Once it gets merged in there should be a release early next week. |
Describe the bug
When navigating to a view model with
var navigationService = Locator.Current.GetService<IParameterViewStackService>(); return navigationService .PushPage(new TimeTrackingDetailPageViewModel(), new NavigationParameter { { "parameter", "test" } });
WhenNavigatedTo is triggered and you can read the parameter.
navigationService .PopPage(new NavigationParameter { { "parameter", "back" } });
Does not trigger WhenNavigatedTo and you are not able to retrieve the parameter
Steps To Reproduce
Take the "Navigation.Parameters" sample - https://github.com/reactiveui/ReactiveUI.Samples/tree/master/xamarin-forms/Navigation.Parameters
Extend the ReceivedViewModel to have a command which calls the "PopPage(...)"
Override WhenNavigatingTo in PassViewModel
Expected behavior
WhenNavigatingTo should always be called when navigating to a view model
Environment
The text was updated successfully, but these errors were encountered: