New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to wrap a modal inside a NavigationPage #98
Comments
Hey @modplug 👋, Thank you for opening an issue. We will get back to you as soon as we can. Also, check out our Open Collective and consider backing us. https://opencollective.com/reactiveui
|
Possibly a regression caused by #96 or even earlier in the 1.7.* Thanks for trying the bleeding edge version and reporting the bug, just a heads up that version 1.7.* is a WIP that will become 2.0 and more suitable for production. |
@modplug If you get the chance can you pull the beta bits and verify this solves your problem? |
When I do PushModal from my viewmodel, the modal shows just fine. But as a good citizen I added a "Close" Toolbar button in the top right corner so that the user can opt out of the modal. The button is never shown because the modal doesn't have a NavigationPage.
I've used similiar frameworks before and I think MvvmCross has an option to "WrapInNavigationPage" when pushing modals.
An alternate solution would perhaps be to do this by using interactions, but that might trick the IViewStackService
There should be an option to wrap it in a NavigationPage.
Additional context
Screenshot nr 2 is the modal page without the NavigationBar.
The text was updated successfully, but these errors were encountered: