New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve API compatibility between and across releases #94
Comments
We cannot and will not guarantee this--especially since RxJava is already stable. The only reason to upgrade RxAndroid at this time is explicitly opting into the new version which will comes with changes, mostly mechanical. Not only is this library finding it's voice and thus no API can be considered stable, but API aesthetics are extremely important to me. Everyone will suffer now so that post-1.0 we can have little to no changes. |
Same here. But temporarily keeping deprecated methods without breaking compatibility sounds like huge part of aesthetics for me. It is also a nice way to get some feedback from those, who don't monitor your repository on daily basis (instead of them quietly rolling out their own libraries to do things in their most aesthetic way).
Ok, will you accept a merge request to get some ViewObservable methods back there? Generating an event object with entire TextView text on every entered symbol sounds like amazing way to trash device RAMs, does not it? |
Like what? I don't use |
Some were moved to WidgetObservable. |
Some breaking changes are unavoidable. We'll try to keep old APIs for at least one minor. |
Also, I just removed the deprecated schedulers in #97 since it's been a whole year. |
We should take aims to explain all breaking changes in the CHANGELOG though, which we haven't been very good about so far. But I agree that we're in "break things" mode right now, for the better good of the initial release. |
@Alexander-- It is a pain to have to update code often, but it is not for self-satisfaction. The cost of API changes is the lowest now while everything is still in flux. The straightjacket of API stability this early on would really slow things down and produce an unwieldy library. |
I don't care, when it is about renaming/moving/reordering. But adding/replacing functionality is usually orders of magnitude harder than temporarily keeping stuff around. Why not do it then?
I have submitted #100.
Sounds reasonable. If no one have objections, feel free to close the issue. |
Removal of things like old ViewObservable methods and moving stuff around is cool and all, but doing so makes all library users (myself included) rewrite lots of code for what amounts to someone's deep self-satisfaction and ~3Kb of code size benefit (with later being nullified by Proguard anyway). I know, that RxAndroid is still a pre-release software, but please at least keep things deprecated for couple of releases before throwing them out of window, especially, when there is a little reason for change besides aesthetics.
The text was updated successfully, but these errors were encountered: