Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BindingObserver and BindingSubscriber mustn't use com.sun* classes #68

Closed
protogenes opened this issue Sep 10, 2018 · 4 comments
Closed

Comments

@protogenes
Copy link
Contributor

The usage of internal com.sun classes breaks on newer Java versions.

./src/main/java/io/reactivex/rxjavafx/observers/BindingObserver.java
import com.sun.javafx.binding.ExpressionHelper;
./src/main/java/io/reactivex/rxjavafx/observers/BindingSubscriber.java
import com.sun.javafx.binding.ExpressionHelper;

@thomasnield
Copy link
Collaborator

Which version(s) is it breaking on? I'm a bit behind and stayed on Java 8, waiting for decoupling to happen with Java 11.

@protogenes
Copy link
Contributor Author

It is breaking with OpenJDK+OpenJFX 11-ea25
At work we are currently stuck on 8u92 because of changes in later updates that break things. With the upcoming release of version 11 in two weeks I wanted to check what dependencies are missing out and preventing an early update as I want to skip 9 and 10 completely.

@thomasnield
Copy link
Collaborator

@protogenes that's my strategy as well. I'll follow up shortly

@thomasnield
Copy link
Collaborator

Resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants