-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error if path has spaces #25
Comments
@dgsmith2 this doesn't seem to solve: rxjs-5-to-6-migrate -p path\ to\ your/tsconfig.json |
Also escaping the path to tsconfig. Usages such as the following should be working: package.json
CLI:
|
This issue needs to be reopened, because it really is a bug that needs to be resolved for Windows users. The file path is not just unescaped for tsconfig, but also the tslint and the rxjs-5-to-6migrate.json, and uses absolute paths. If, for example, your user name in Windows is "First Last", your path will look like "C:\User\First Last..." for all of the above files, breaking the install. |
I've made a pull request that should fix this issue. |
I just looked, there's a week old PR from dgsmith2 with almost exactly the same issue. The failure to accept this PR will be stopping a lot of people from upgrading to Angular 6. It's a hot topic off the back off IO18, so this should be seen to sooner rather than later. |
yes this issue is big barrier to migrate angular 5 to angular 6 :( |
Fixed and published as part of 0.1.4. |
If your project has a space in its path the call to
execSync
will fail because the unescaped space(s) causes the remainder of the command to be interpreted as command-line argument(s).The text was updated successfully, but these errors were encountered: