You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi after running: rxjs-5-to-6-migrate -p ./tsconfig.json there seems to be a problem with some of my observable definitions as a comma (,) is being added at the end of the chain.
Please see some examples below:
BEFORE
returnthis.httpService.patch(url,body).do((response: any)=>{// do stuff}).catch(e=>this.isError409(e));
AFTER
returnthis.httpService.patch(url,body).pipe(tap((response: any)=>{// do stuff}),catchError(e=>this.isError409(e)),);
As you can see at the catchError line a , was added.
Hey @ndcunningham, thanks for giving the tool a try! I'm happy you were able to migrate your app. The trailing comma is not an invalid syntax. As we've recommended in readme, after you run the migration tool, you can format your code with prettier or clang-format to make sure everything aligns with your coding style.
Hi after running:
rxjs-5-to-6-migrate -p ./tsconfig.json
there seems to be a problem with some of my observable definitions as a comma (,
) is being added at the end of the chain.Please see some examples below:
BEFORE
AFTER
As you can see at the
catchError
line a,
was added.Another example is here:
BEFORE
AFTER
Is this expected?
Is there a CLI flag that i might have missed?
Thank you.
The text was updated successfully, but these errors were encountered: