Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mix #6

Open
elvisbegovic opened this issue Apr 11, 2018 · 5 comments
Open

fix mix #6

elvisbegovic opened this issue Apr 11, 2018 · 5 comments

Comments

@elvisbegovic
Copy link

For unknown reasons one file in my code contains this code (certainly months ago when update to pipeable manually I omit this ... it compile = i forget)

import "rxjs/add/operator/distinctUntilChanged";
...
this.form.get('iban').valueChanges.pipe(takeUntil(<Observable<any>> this.ngUnsubscribe))
      .distinctUntilChanged()
      .subscribe(this.onChange_iban.bind(this));

When running tslint my migrate-rxjs.tslint.json nothing change ^^
Is it relevant to fix this kind of code too?

@benlesh
Copy link
Member

benlesh commented Apr 12, 2018

I've tried this locally and I didn't have an issue. Do you have a minimal file that reproduces the issue?

@elvisbegovic
Copy link
Author

if you compile this green cli6rc4 project issue6.zip with this rxjs-tslint and say it's normal behavior please close issue

FYI: all is inside app.component.ts

I was thinking here outdated will be removed and distinctUntilChange will move inside pipe() with correct path import but ok...

@Airblader
Copy link

I'm having the same issue that rxjs-5-to-6-migrate only converted the first operator to using pipe, but left all other chained operators untouched (which breaks the build due to changed imports)

@geogramdotcom
Copy link

same issue for me. Im having to move all my .map operators by hand

@Airblader
Copy link

What ended up working for me was running the command multiple times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants