fix(ScalarObservable): set _isScalar to false when initialized with a scheduler. #1674
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
ScalarObservable's
_isScalar
flag was permanentlytrue
, even if initialized with ascheduler
. This caused our internalsubscribeToResult
helper to short-circuit subscribing to theScalarObservable
, so the emission was never scheduled. This PR changes that.Related issue (if exists):
None yet.