refactor(throwError): remove utility throwError() function

[kwonoj]

Description:

This PR removes utility function throwError, which simply wraps throw and only being used in single place. Error can be thrown directly.

Related issue (if exists):

[coveralls]

Coverage decreased (-0.001%) to 96.471% when pulling 20a0de2 on kwonoj:refactor-throwError into 3632489 on ReactiveX:master.

[kwonoj]

Not sure why coverage's decreased :/

[coveralls]

Coverage increased (+0.03%) to 96.501% when pulling 97819eb on kwonoj:refactor-throwError into 4971993 on ReactiveX:master.

[jayphelps]

Was this being done for performance reasons? I'm not aware of any, but wouldn't be surprised if wrapping the throw inside a function some how prevented a deopt or something. @Blesh ?

[kwonoj]

Was this being done for performance reasons? I'm not aware of any

I was also bit curious, sending out PR as discussion point, especially this has been used in only single place of codebase.

[coveralls]

Coverage decreased (-0.001%) to 96.471% when pulling 26685b1 on kwonoj:refactor-throwError into 19f4362 on ReactiveX:master.

[benlesh]

TMK, throw doesn't cause a deopt. I'm not sure why this function existed.

Need to make sure the code coverage stays up, other than that, it LGTM

[coveralls]

Coverage decreased (-0.001%) to 96.471% when pulling bdb9dbd on kwonoj:refactor-throwError into 19f4362 on ReactiveX:master.

[jayphelps]

coveralls doesn't make sense to me. It says in the list of changes that there was no change in coverage, but then claims -0.001% overall change. Seems like a rounding error or something...

[jayphelps]

LGTM

[kwonoj]

coveralls doesn't make sense to me. It says in the list of changes that there was no change in coverage, but then claims -0.001% overall change. Seems like a rounding error or something

I assume similar, some kind of threshold between line changes. Tried dummy changes but no luck. :/
Let me check this in once current travis result comes back. Thanks for review @Blesh , @jayphelps .

[coveralls]

Coverage decreased (-0.001%) to 96.471% when pulling bdb9dbd on kwonoj:refactor-throwError into 19f4362 on ReactiveX:master.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.