fix(Observable): Update typings of pipe #3789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added <any, any>[] as tyings for the generic type of operators provided to the pipe, as OperatorFunctions can transform the type. 3766
benlesh
approved these changes
Jun 5, 2018
|
LGTM... Thanks, @akehir! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added <any, any>[] as tyings for the generic type of operators provided to the pipe, as
OperatorFunctions can transform the type.
The fix is as suggested by @cartant here: #3766 (comment)
Travis CI passes for typescript current, but not for next (not related to my change): https://travis-ci.org/akehir/rxjs/builds/388179712
Related issue (if exists):
#3766