Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(isEmpty): improve documentation #5149

Merged
merged 1 commit into from
Nov 28, 2019
Merged

docs(isEmpty): improve documentation #5149

merged 1 commit into from
Nov 28, 2019

Conversation

dzhavat
Copy link
Contributor

@dzhavat dzhavat commented Nov 17, 2019

Description:

  • Change code examples to ts
  • Fix link to EMPTY
  • General improvements

Related issue (if exists):

niklas-wortmann
niklas-wortmann approved these changes Nov 28, 2019
View reviewed changes
Copy link
Member

@niklas-wortmann niklas-wortmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for improving the docs here

@niklas-wortmann niklas-wortmann merged commit 8470638 into ReactiveX:master Nov 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@niklas-wortmann niklas-wortmann niklas-wortmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dzhavat @niklas-wortmann