docs(combineLatest): changed examples of code to not use deprecated code #5151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklas-wortmann
approved these changes
Nov 30, 2019
|
I just realized that force pushing may not have been the right choice. Is that what I'm supposed to do on the forked repo? |
Yep. That's fine. That's what's expected when you rebase and resolve the conflicts. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent commit 6661c79 a whole bunch of combineLatest calling forms were deprecated, but the docs weren't updated. I've now updated the docs for combineLatest to remove any references to the old way.