Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mergeWith #5252

Merged
merged 2 commits into from Jan 22, 2020
Merged

Add mergeWith #5252

merged 2 commits into from Jan 22, 2020

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Jan 21, 2020

  • Updates tests
  • Adds docs
  • Updates deprecation messages
  • Adds dtslint tests

@benlesh benlesh requested a review from cartant January 21, 2020 04:37
cartant
cartant approved these changes Jan 22, 2020
View reviewed changes
Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benlesh benlesh merged commit baf1442 into ReactiveX:master Jan 22, 2020
kwonoj pushed a commit to kwonoj/rxjs that referenced this pull request Feb 5, 2020
@benlesh @kwonoj
Add mergeWith (ReactiveX#5252)
2d49fe7 
* feat(mergeWith): add mergeWith

* test(mergeWith): update tests
martinsik pushed a commit to martinsik/rxjs that referenced this pull request Feb 15, 2020
@benlesh
Add mergeWith (ReactiveX#5252)
12f33c4 
* feat(mergeWith): add mergeWith

* test(mergeWith): update tests
@lock lock bot locked as resolved and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cartant cartant cartant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benlesh @cartant