Single operator fixes #5325
Single operator fixes #5325
Conversation
| import { single, mergeMap, tap } from 'rxjs/operators'; | ||
| import { of, EmptyError } from 'rxjs'; | ||
|
|
||
| declare function asDiagram(arg: string): Function; |
There was a problem hiding this comment.
IDK what the consequences of removing this asDiagram business are? Will it break website images when the docs are re-created?
There was a problem hiding this comment.
From what I remember, we stop generating them like this, and we're just using old, static images. @jwo719, can you confirm this? I've been removing these asDiagram calls when I see them.
There was a problem hiding this comment.
Lol I never noticed. So it's kinda true, that we are using a static old version of the generated marbleDiagrams, but there's a pr and several issues to improve this mechanism and IIRC it's still using this asDiagram function, so it would be good to keep it for now. I can go through the history to find the deleted images.
This explains now why there is always a diff when I try to generate the new images :D
There was a problem hiding this comment.
@niklas-wortmann ... can you please set up a separate issue? I've been removing these for the last year at least, because at one point we stopped using them. It's always the first test in the file that had it before. It would be nice if this was something that was imported and used, rather than a global variable, too.
- Will now throw new NotFoundError and SequenceError types in appropriate scenarios - Updates documentation BREAKING CHANGE: Single will now throw for scenarios where values coming in are either not present, or do not match the provided predicate. Error types have thrown have also been updated, please check documentation for changes.
benlesh
force-pushed
the
single-operator-fixes
branch
from
8f1731d
to
466295f
Compare
This reverts commit 27931bc.
Per our discussion of #5320, this is a set of fixes to the behavior of single, which was wildly incorrect. Modernizes and updates tests. Rewrites the operator in the newer functional style.
BREAKING CHANGES:
single()will now throw if more than one value comes from the source. Previously it would not emit.single(predicate), in cases where nothing matches the predicate, will now throw aNotFoundErrorif nothing matched, and anEmptyErrorif the source simply did not emit any values.single(predicate)on an empty source will now emit anEmptyError. Previously it would erroneously emitundefined.