Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation notes #5821

Merged
merged 7 commits into from Mar 13, 2021
Merged

Conversation

niklas-wortmann
Copy link
Member

This are the important deprecation notes from my point of view. We introduced some breaking changes recently, but I personally would keep these information in the changelog, those feel very edgy to me.

closes #4776 ?

Copy link
Member

@benlesh benlesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than one duplicated bit.

@benlesh
Copy link
Member

benlesh commented Oct 13, 2020

Related to discussion here: #5824

@niklas-wortmann
Copy link
Member Author

I updated this pr to align with #5824 and also I created a page for the breaking changes

Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm merging this 'cause it's a docs-only change, 'cause the deprecations effect an inordinate amount of confusion and need to be sorted out and because keeping a PR that's been open for 6 months in sync with the changes that accrue in the branch it targets is a PITA.

@cartant
Copy link
Collaborator

cartant commented Mar 13, 2021

FWIW, over the next few days, I'll be working on fixing some issues with deprecations and that will be much easier now that this PR has been merged.

@cartant cartant merged commit 0abe519 into ReactiveX:master Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create documentation for deprecations and breaking changes and add URLs messages
3 participants