Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update finalize tests to run mode #5905

Merged
merged 1 commit into from Nov 25, 2020
Merged

chore: update finalize tests to run mode #5905

merged 1 commit into from Nov 25, 2020

Conversation

jakovljevic-mladen
Copy link
Member

Description:
Updated finalize tests to use run mode.

One note: I didn't want to add testScheduler and beforeEach to the describe callback (as it's usually done in other tests) because many of the tests in this suite don't use testScheduler instance, so I was creating them where they were needed.

Related issue (if exists):
None

cartant
cartant approved these changes Nov 25, 2020
View reviewed changes
Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cartant cartant merged commit e5402fc into ReactiveX:master Nov 25, 2020
@jakovljevic-mladen jakovljevic-mladen deleted the finalize_run_mode branch November 25, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartant cartant cartant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakovljevic-mladen @cartant