Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Progression Syntax example in the Marble Testing section #5988

Conversation

DawChihLiou
Copy link
Contributor

@DawChihLiou DawChihLiou commented Jan 26, 2021

Correct Time progression syntax example

Description:
In the Time Progression Syntax section under Marble Testing, one of the examples's description is incorrect. Please see the example and the updated description below:

Current: 'a 9ms b 9s c|': on frame 0 emit a, on frame 10 emit b, on frame 10,012 emit c, then on on frame 10,013 complete.
Updated: 'a 9ms b 9s c|': on frame 0 emit a, on frame 10 emit b, on frame 9,011 emit c, then on on frame 9,012 complete.

Related issue (if exists):
#5977

Correct Time progression syntax examples.

Current: 'a 9ms b 9s c|': on frame 0 emit a, on frame 10 emit b, on frame 10,012 emit c, then on on frame 10,013 complete.
Updated: 'a 9ms b 9s c|': on frame 0 emit a, on frame 10 emit b, on frame 9,011 emit c, then on on frame 9,012 complete.
@DawChihLiou DawChihLiou changed the title Update marble-testing.md Correct Progression Syntax example in the Marble Testing section Jan 26, 2021
@benlesh benlesh merged commit d20b1b8 into ReactiveX:master Jan 26, 2021
@benlesh
Copy link
Member

benlesh commented Jan 26, 2021

Whoops! Thanks, @DawChihLiou!

@jakovljevic-mladen
Copy link
Member

@benlesh, please consider closing #5977 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants