fix: publish variants returning ConnectableObservable not properly utilizing lift #6003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
benlesh
commented
Feb 8, 2021
benlesh
commented
- Adds tests to show fixed issues
- Adds tests to show issues that simply can't be fixed, and support a case against removing operators that return ConnectableObservable, as well as possibly a case against lifting Subject.
- Moves logic that patched lift for ConnectableObservable to the constructor so it is used by all multicast operators
…ilizing lift - Adds tests to show fixed issues - Adds tests to show issues that simply can't be fixed, and support a case against removing operators that return ConnectableObservable, as well as possibly a case against lifting Subject. - Moves logic that patched lift for ConnectableObservable to the constructor so it is used by all multicast operators
benlesh
force-pushed
the
fix/publish-operators-not-composing-custom-observables
branch
from
9a011c6
to
f722f0a
Compare
cartant
approved these changes
Feb 8, 2021
Comment on lines
+921
to
+924
| /** | ||
| * Seriously, never do this. It's probably bad that we've allowed this. Fortunately, it's not | ||
| * a common practice, so maybe we can remove it? | ||
| */ |
There was a problem hiding this comment.
OMG, don't give those naughty devs more ideas! 😬 🙈
Comment on lines
+960
to
+961
| * If you're a user and you're reading this... NEVER try to use this feature, it's likely | ||
| * to go away at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.