refactor(combineLatest): small efficiency changes #6021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
benlesh
commented
Feb 12, 2021
benlesh
commented
- no longer use an array to track first value emission
- inline a few things than can be inlined
- adds more comments
benlesh
commented
Feb 12, 2021
| * inner firehose observables can teardown in the event of a `take` or the like. | ||
| * @internal | ||
| */ | ||
| class CombineLatestSubscriber<T> extends Subscriber<T> { |
There was a problem hiding this comment.
We don't need this, we can use OperatorSubscriber.
benlesh
commented
Feb 12, 2021
| // The number of inner sources that still haven't emitted the first value | ||
| // We need to track this because all sources need to emit one value in order | ||
| // to start emitting values. | ||
| let remainingFirstValues = length; |
There was a problem hiding this comment.
Here I'm using a countdown, instead of an array, to track whether or not each source has emitted at least one value.
- no longer use an array to track first value emission - inline a few things than can be inlined - adds more comments
benlesh
force-pushed
the
blesh/refactor-combineLatest-small-efficiency-improvements
branch
from
c026e2d
to
5c67d95
Compare
cartant
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.