Feat/ajax response headers #6057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlesh
force-pushed
the
feat/ajax-response-headers
branch
from
bf93b90
to
bba710f
Compare
|
Ugh... |
|
No biggy... it's probably more efficient as a reduce :) |
benlesh
force-pushed
the
feat/ajax-response-headers
branch
from
cd4e448
to
e5dcb0d
Compare
cartant
approved these changes
Feb 26, 2021
Comment on lines
+99
to
+109
| this.responseHeaders = allHeaders | ||
| ? // Split the header text into lines | ||
| allHeaders.split('\n').reduce((headers: Record<string, string>, line) => { | ||
| // Split the lines on the first ": " as | ||
| // "key: value". Note that the value could | ||
| // technically have a ": " in it. | ||
| const index = line.indexOf(': '); | ||
| headers[line.slice(0, index)] = line.slice(index + 2); | ||
| return headers; | ||
| }, {}) | ||
| : {}; |
There was a problem hiding this comment.
Maybe we could implement responseHeaders as a getter so that the headers don't have to be parsed for every response?
There was a problem hiding this comment.
I did that initially, but then I had a add a private property, tests got messy, I got lazy because it was 2am, etc. Happy to take another pass at that in a follow up PR, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a feature that allows the user to examine response headers more easily (based loosely off of prior art from contemporary libraries):