chore: remove bindCallback workaround #6063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, this relies upon a 4.2 feature, so TS 4.2 will need to be our minimum supported version. For 4.1 to be our minimum, we'd have to re-instate the workaround, as 4.2 deems our previous signatures to be incompatible. Once again, a TS minor-version release is breaking. |
benlesh
approved these changes
Mar 1, 2021
It seems like the output .d.ts files would be okay for 4.1 though, no? Either way, this seems like what we want to land in 7. So... 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR removes the workaround type that was added for
bindCallbackin #6050. TypeScript is correct that the signatures aren't compatible because callback arguments are contravariant.Related PR: #6050