Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip legacy formatting #6137

Merged
merged 3 commits into from Mar 14, 2021
Merged

Zip legacy formatting #6137

merged 3 commits into from Mar 14, 2021

Conversation

tmair
Copy link
Contributor

@tmair tmair commented Mar 14, 2021

Description:
This PR introduces prettier formatting in zip Legacy tests. One use of the deprecated subscribe signature is replaced and anonymous functions are converted to arrow functions.

Related issue (if exists):
None

Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for splitting the changes into separate commits. Very easy to review.

@cartant cartant merged commit 4805a7f into ReactiveX:master Mar 14, 2021
@tmair tmair deleted the zip-legacy-formatting branch March 14, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants