docs(operators): fix code example #6577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diyews
force-pushed
the
fix-operator-code-example
branch
from
8891915
to
1b00c7c
Compare
diyews
force-pushed
the
fix-operator-code-example
branch
from
1b00c7c
to
34ef4cd
Compare
diyews
commented
Aug 23, 2021
| * const div = document.createElement('div'); | ||
| * div.style.cssText = `width: 200px;height: 200px;background: #09c;`; | ||
| * document.body.appendChild(div); | ||
| * | ||
| * const clicks = fromEvent(document, 'click'); |
There was a problem hiding this comment.
BTW, find, findIndex, first all need a div element to run the example. Or maybe we can refactor to use Typescript only, eg:
range(1, 10)
.pipe(filter(x => x % 2 === 1))
Co-authored-by: Mladen Jakovljević <jakovljevic.mladen@gmail.com>
diyews
force-pushed
the
fix-operator-code-example
branch
from
a11fdde
to
3e75d9c
Compare
benlesh
reviewed
Aug 31, 2021
benlesh
reviewed
Aug 31, 2021
benlesh
reviewed
Aug 31, 2021
benlesh
approved these changes
Aug 31, 2021
|
😢 My mistake, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Going to fix code examples so that can run in stackblitz.