Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document and export TapObserver #6944

Conversation

jakovljevic-mladen
Copy link
Member

Description:
Added documentation and an example to the TapObserver. Also, in regards to #6943, I didn't use export type syntax, but I used only export syntax which made TapObserver page to appear in the docs app.

image

Related issue (if exists):
None

@benlesh
Copy link
Member

benlesh commented Mar 7, 2023

@jakovljevic-mladen this can be merged into master and 7.x

@benlesh benlesh added 7.x Issues and PRs for version 6.x 8.x Issues and PRs for version 8.x labels Mar 7, 2023
@jakovljevic-mladen jakovljevic-mladen merged commit fe90d9b into ReactiveX:master Mar 9, 2023
@jakovljevic-mladen jakovljevic-mladen deleted the export_and_document_TapObserver branch March 9, 2023 08:10
jakovljevic-mladen added a commit that referenced this pull request Mar 9, 2023
* docs: document and export TapObserver

* docs(TapObserver): fix typos

* docs: remove docs for the removed tap operator params

(cherry picked from commit fe90d9b)
@jakovljevic-mladen
Copy link
Member Author

Cherry-picked to 7.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7.x Issues and PRs for version 6.x 8.x Issues and PRs for version 8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants