Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Observer): add documentation to Observer interface #6948

Conversation

jakovljevic-mladen
Copy link
Member

Description:
Since I proposed a TapObserver documentation page PR (#6944), I thought that we should document the Observer interface page as well. Although there are a guide and a glossary pages that explain most of what I wrote in this PR (which I also mentioned in this PR), I wanted to still add the basic documentation to the Observer interface page which users can encounter while roaming the docs app (which is empty for now).

This is how these changes look like:

image

Related issue (if exists):
None

@jakovljevic-mladen jakovljevic-mladen force-pushed the add_Observer_interface_documentation branch from c5ce4ae to 031c485 Compare December 15, 2022 10:38
@benlesh
Copy link
Member

benlesh commented Mar 7, 2023

This can be merged into master and 7.x

@benlesh benlesh added 7.x Issues and PRs for version 6.x 8.x Issues and PRs for version 8.x labels Mar 7, 2023
@jakovljevic-mladen jakovljevic-mladen merged commit 667e185 into ReactiveX:master Mar 9, 2023
@jakovljevic-mladen jakovljevic-mladen deleted the add_Observer_interface_documentation branch March 9, 2023 08:11
jakovljevic-mladen added a commit that referenced this pull request Mar 9, 2023
* docs(Observer): add documentation to Observer interface

* docs(Observer): remove unused docs annotation

(cherry picked from commit 667e185)
@jakovljevic-mladen
Copy link
Member Author

Cherry-picked to 7.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7.x Issues and PRs for version 6.x 8.x Issues and PRs for version 8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants