Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Workflows security hardening #7048

Merged
merged 1 commit into from Sep 25, 2022
Merged

Conversation

sashashura
Copy link
Contributor

This PR adds explicit permissions section to workflows. This is a security best practice because by default workflows run with extended set of permissions (except from on: pull_request from external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted.
It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.

@sashashura
Copy link
Contributor Author

Is there anyone else approve needed?

@jakovljevic-mladen
Copy link
Member

No, Ben's approval is enough. He'll merge it once he finds enough time. The project is 100% based on voluntary work, please have understanding.

@benlesh benlesh merged commit 54b36cb into ReactiveX:master Sep 25, 2022
@benlesh
Copy link
Member

benlesh commented Sep 25, 2022

Thank you, @sashashura

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants