feat(Observable): RxJS doesn't even lift. #7202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlesh
force-pushed
the
maybe-remove-lift
branch
2 times, most recently
from
5bd1e2e
to
d9caf67
Compare
benlesh
changed the title
+ Removes `lift`, `source`, and `operator` from `Observable` + Updates related code BREAKING CHANGE: `Observable#lift`, `Observable#source`, and `Observable#operator` is no longer a part of the API. These were never meant to be public and have been deprecated for more than 3 years. Resolves ReactiveX#7201
benlesh
force-pushed
the
maybe-remove-lift
branch
from
d9caf67
to
c921203
Compare
|
|
demensky
reviewed
Mar 2, 2023
| @@ -108,7 +100,7 @@ export class Subject<T> extends Observable<T> implements SubscriptionLike { | |||
|
|
|||
| /** @internal */ | |||
| protected _subscribe(subscriber: Subscriber<T>): Subscription { | |||
| this._throwIfClosed(); | |||
| // this._throwIfClosed(); | |||
There was a problem hiding this comment.
Is there any additional change planned?
Suggested change
| // this._throwIfClosed(); |
Comment on lines
9
to
11
| export function operate<T, R>( | ||
| init: (liftedSource: Observable<T>, subscriber: Subscriber<R>) => (() => void) | void | ||
| ): OperatorFunction<T, R> { |
There was a problem hiding this comment.
Suggested change
| export function operate<T, R>( | |
| init: (liftedSource: Observable<T>, subscriber: Subscriber<R>) => (() => void) | void | |
| ): OperatorFunction<T, R> { | |
| export function operate<T, R>( | |
| init: (source: Observable<T>, subscriber: Subscriber<R>) => (() => void) | void | |
| ): OperatorFunction<T, R> { |
Probably JSDoc should also be updated.
There was a problem hiding this comment.
I'll address this in a followup.
| @@ -17,16 +9,5 @@ export function hasLift(source: any): source is { lift: InstanceType<typeof Obse | |||
| export function operate<T, R>( | |||
| init: (liftedSource: Observable<T>, subscriber: Subscriber<R>) => (() => void) | void | |||
| ): OperatorFunction<T, R> { | |||
| return (source: Observable<T>) => { | |||
There was a problem hiding this comment.
Well, the file name is no longer true.
There was a problem hiding this comment.
I'll address this in a followup.
benlesh
added
AGENDA ITEM
|
I blame @jayphelps |
|
@benlesh so do I. |
kolodny
approved these changes
Mar 8, 2023
| protected _subscribe(subscriber: Subscriber<any>): TeardownLogic { | ||
| return this.source?.subscribe(subscriber); | ||
| protected _subscribe(_subscriber: Subscriber<any>): TeardownLogic { | ||
| return; |
There was a problem hiding this comment.
Can we just use an empty body here?
| @@ -237,7 +237,7 @@ describe('delay', () => { | |||
| const result = e1.pipe( | |||
| repeatWhen((notifications) => { | |||
| const delayed = notifications.pipe(delay(t)); | |||
| subscribeSpy = sinon.spy((delayed as any)['source'], 'subscribe'); | |||
| subscribeSpy = sinon.spy(notifications as any, 'subscribe'); | |||
There was a problem hiding this comment.
Small nit but I believe you can do sinon.spy<any>(notifications) instead
| observer.complete(); | ||
| return { | ||
| unsubscribe() { | ||
| // noop |
There was a problem hiding this comment.
Do we want to verify this was called? If not can we remove this?
benlesh
added a commit
to benlesh/rxjs
that referenced
this pull request
Apr 15, 2023
+ Inlines all operator function creation as just arrow functions. After `lift` was removed, there is no use for the `operate` function. Related ReactiveX#7202
Merged
benlesh
added a commit
that referenced
this pull request
Apr 17, 2023
* refactor: Remove `operate` function + Inlines all operator function creation as just arrow functions. After `lift` was removed, there is no use for the `operate` function. Related #7202 * refactor(find): reduce complexity in function calls + Removes use of higher-order function, as it's no longer necessary, because we're not using `operate`, because we don't even `lift`. * refactor(scan/reduce): reduce complexity in function calls + Removes use of higher-order function, as it's no longer necessary, because we're not using `operate`, because we don't even `lift`. * chore: Address comments * chore: forgot to commit
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
lift,source, andoperatorfrom the Observable API. These have been deprecated for more than 3 years. It's time.#7201