Fix 6805: remove strange groupBy behavior #7252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`groupBy` no longer supports the behavior where inner subscriptions will cause the outer subscription to stay connected after consumer unsubscribes from result. Resolves ReactiveX#6805 BREAKING CHANGE: `groupBy` no longer allows grouped observable subscriptions to stay connected after parent subscription unsubscribed. If you need this behavior, don't unsubscribe from the parent.
+ Stopped exporting `OperatorSubscriber` class from module + Updated `onErrorResumeNext` and a `Subject` test to use `createOperatorSubscriber`
niklas-wortmann
requested review from
niklas-wortmann
and removed request for
niklas-wortmann
jakovljevic-mladen
approved these changes
Apr 26, 2023
Comment on lines
168
to
174
| // Capturing a reference to this, because we need a handle to it | ||
| // in `createGroupedObservable` below. This is what we use to | ||
| // subscribe to our source observable. This sometimes needs to be unsubscribed | ||
| // out-of-band with our `subscriber` which is the downstream subscriber, or destination, | ||
| // in cases where a user unsubscribes from the main resulting subscription, but | ||
| // still has groups from this subscription subscribed and would expect values from it | ||
| // Consider: `source.pipe(groupBy(fn), take(2))`. |
There was a problem hiding this comment.
Revisit this comment.
ktrz
reviewed
May 3, 2023
| // Capturing a reference to this, because we need a handle to it | ||
| // in `createGroupedObservable` below. This is what we use to | ||
| // subscribe to our source observable. This sometimes needs to be unsubscribed | ||
| // out-of-band with our `subscriber` which is the downstream subscriber, or destination, | ||
| // in cases where a user unsubscribes from the main resulting subscription, but | ||
| // still has groups from this subscription subscribed and would expect values from it | ||
| // Consider: `source.pipe(groupBy(fn), take(2))`. | ||
| const groupBySourceSubscriber = new OperatorSubscriber( | ||
| const groupBySourceSubscriber = createOperatorSubscriber( | ||
| subscriber, | ||
| (value: T) => { | ||
| // Because we have to notify all groups of any errors that occur in here, |
There was a problem hiding this comment.
GH didn't allow me to put a comment in the exact spot lines 189-191 here but I think the comment also needs revisiting as the mentioned reference counting seem to be removed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(groupBy): will no longer leak inner subscriptions
groupByno longer supports the behavior where inner subscriptions will cause the outer subscription to stay connected after consumer unsubscribes from result.Resolves #6805
BREAKING CHANGE:
groupByno longer allows grouped observable subscriptions to stay connected after parent subscription unsubscribed. If you need this behavior, don't unsubscribe from the parent.refactor: Remove direct instantiation of
OperatorSubscriberOperatorSubscriberclass from moduleonErrorResumeNextand aSubjecttest to usecreateOperatorSubscriberActual stream of the work is here, if that helps: https://youtu.be/rHgED1U6XDY