Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): remove global test scheduler #7258

Merged
merged 5 commits into from May 24, 2023

Conversation

tmair
Copy link
Contributor

@tmair tmair commented May 7, 2023

Description:
This PR removes the global rxTestScheduler from the test infrastructure. To get this working it was necessary to also remove the tests for the global test scheduler.

In addition the custom mocha UI was also removed because it is no loger necessary.

@benlesh
Copy link
Member

benlesh commented May 19, 2023

This is great, @tmair ... it looks like there's a conflict though.

@tmair tmair force-pushed the remove-global-test-scheduler branch from 410e651 to f97ef76 Compare May 22, 2023 09:23
@tmair
Copy link
Contributor Author

tmair commented May 22, 2023

it looks like there's a conflict though.
I rebased my branch and resolved the conflict.

@@ -1,15 +1,14 @@
/** @prettier */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this is the last PR where we have this line included. Can we update .prettierrc.json and completely remove "overrides" filed from it? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakovljevic-mladen I created a draft PR that removes the pragma and the spec directory from the prettier formatting override. Please have a look at #7275. If we would like to merge those changes I can update the PR and promote it to a proper PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we would like to merge those changes I can update the PR and promote it to a proper PR.

I think we do. Great @tmair, thanks a bunch!

@benlesh benlesh merged commit c773919 into ReactiveX:master May 24, 2023
3 checks passed
@benlesh
Copy link
Member

benlesh commented May 24, 2023

Thank you so much, @tmair !

@tmair tmair deleted the remove-global-test-scheduler branch May 25, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants