fix(forkJoin): the first empty source will now cause an EmptyError #7266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LcsGa
approved these changes
May 19, 2023
demensky
approved these changes
May 22, 2023
BREAKING CHANGE: `forkJoin` will no longer just complete if a source completes without a value. Instead you will get an error of `EmptyError`. If you want to complete in this case, add `catchError(() => EMPTY)` to the forkJoin... however, if you just want to default the sources of your `forkJoin` to some other value if they're empty, apply the `defaultIfEmpty` operator. for example, `forkJoin(sources.map(defaultIfEmpty(null)))`. resolves ReactiveX#5561
benlesh
force-pushed
the
fix-5561_forkJoin-early-complete
branch
from
03f0e25
to
82184b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
forkJoinwill no longer just complete if a source completes without a value. Instead you will get an error ofEmptyError. If you want to complete in this case, addcatchError(() => EMPTY)to the forkJoin... however, if you just want to default the sources of yourforkJointo some other value if they're empty, apply thedefaultIfEmptyoperator. for example,forkJoin(sources.map(defaultIfEmpty(null))).resolves #5561