Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Subscriber): next method no longer has optional value argument #7290

Merged
merged 1 commit into from Jun 19, 2023

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Jun 19, 2023

Resolves #2852
Related #7172

@benlesh benlesh merged commit 1c5673f into ReactiveX:master Jun 19, 2023
3 checks passed
@josepot
Copy link
Contributor

josepot commented Oct 26, 2023

I just faced a nasty runtime error that could have been avoided if this fix had already been shipped. I'd like to know: will there be a release patch containing this fix? Or will it be treated as a "breaking change," meaning we'll need to wait for version 8?

FWIW, I strongly believe this deserves a patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subject.prototype.next() should only accept T, not T | undefined
3 participants